Doc / Removed model reference in client.create of extraction example.#1951
Merged
jxnl merged 1 commit into567-labs:mainfrom Nov 28, 2025
Merged
Doc / Removed model reference in client.create of extraction example.#1951jxnl merged 1 commit into567-labs:mainfrom
jxnl merged 1 commit into567-labs:mainfrom
Conversation
client.create is specifying the model once agin, while model is already specified in instructor.from_provider. Removed model agreement to avoid confusion to the reader.
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 383652d in 1 minute and 14 seconds. Click for details.
- Reviewed
19lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/learning/getting_started/first_extraction.md:27
- Draft comment:
Removed the duplicate 'model' parameter from client.create() to prevent redundancy. The model is already set when using from_provider(). - Reason this comment was not posted:
Comment looked like it was already resolved.
2. docs/learning/getting_started/first_extraction.md:136
- Draft comment:
Ensure a trailing newline at the end of the file for consistent formatting. - Reason this comment was not posted:
Confidence changes required:33%<= threshold85%None
Workflow ID: wflow_B1QIWaPYOGnsVXtM
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client.create is specifying the model once agin, while model is already specified in instructor.from_provider.
Removed model agreement to avoid confusion to the reader.
Important
Remove redundant
modelparameter inclient.create()example infirst_extraction.md.modelparameter inclient.create()infirst_extraction.mdexample, as the model is already specified ininstructor.from_provider().This description was created by
for 383652d. You can customize this summary. It will automatically update as commits are pushed.