Skip to content

Doc / Removed model reference in client.create of extraction example.#1951

Merged
jxnl merged 1 commit into567-labs:mainfrom
grokthetech-netizen:patch-1
Nov 28, 2025
Merged

Doc / Removed model reference in client.create of extraction example.#1951
jxnl merged 1 commit into567-labs:mainfrom
grokthetech-netizen:patch-1

Conversation

@grokthetech-netizen
Copy link
Copy Markdown
Contributor

@grokthetech-netizen grokthetech-netizen commented Nov 27, 2025

client.create is specifying the model once agin, while model is already specified in instructor.from_provider.
Removed model agreement to avoid confusion to the reader.


Important

Remove redundant model parameter in client.create() example in first_extraction.md.

  • Documentation:
    • Removed redundant model parameter in client.create() in first_extraction.md example, as the model is already specified in instructor.from_provider().

This description was created by Ellipsis for 383652d. You can customize this summary. It will automatically update as commits are pushed.

client.create is specifying the model once agin, while model is already specified in instructor.from_provider. 

Removed model agreement to avoid confusion to the reader.
Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 383652d in 1 minute and 14 seconds. Click for details.
  • Reviewed 19 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/learning/getting_started/first_extraction.md:27
  • Draft comment:
    Removed the duplicate 'model' parameter from client.create() to prevent redundancy. The model is already set when using from_provider().
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. docs/learning/getting_started/first_extraction.md:136
  • Draft comment:
    Ensure a trailing newline at the end of the file for consistent formatting.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 85% None

Workflow ID: wflow_B1QIWaPYOGnsVXtM

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@jxnl jxnl merged commit 130c034 into 567-labs:main Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants