Conversation
Integrates Databricks models with instructor. Co-authored-by: jason <jason@jxnl.co>
|
Cursor Agent can help with this pull request. Just |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
instructor | 8070043 | Nov 12 2025, 12:13 AM |
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 8070043 in 2 minutes and 6 seconds. Click for details.
- Reviewed
310lines of code in3files - Skipped
0files when reviewing. - Skipped posting
6draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/integrations/databricks.md:15
- Draft comment:
Confirm if the command 'uv pip install instructor openai' is intentional. 'uv' looks unusual; did you mean 'pip install instructor openai'? - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 85%uvis a real, legitimate Python package installer that has gained significant traction in the Python community. It's not a typo - it's a modern alternative to pip that's faster and more reliable. The change frompip installtouv pip installappears to be an intentional modernization of the documentation. The comment assumes this is an error when it's actually a valid tool choice. This violates the rule about not making speculative comments and assumes the author made a mistake when they likely didn't. Coulduvbe uncommon enough that users might be confused by it? Perhaps the comment is trying to be helpful by flagging something that might confuse readers, even ifuvis technically correct. Whileuvmight be unfamiliar to some users, the comment is asking the PR author to "confirm if intentional" which violates the rule against asking authors to confirm their intention or double-check things. If the author changed it touv, they clearly intended to do so. The comment doesn't provide value and should be deleted. This comment should be deleted. It incorrectly assumesuvis a typo when it's actually a legitimate Python package installer. The comment also violates the rule against asking authors to confirm their intention or double-check their changes.
2. instructor/auto_client.py:284
- Draft comment:
Consider refactoring the base URL normalization logic into a helper function to follow DRY principles. - Reason this comment was not posted:
Confidence changes required:50%<= threshold85%None
3. instructor/auto_client.py:267
- Draft comment:
The new Databricks provider branch is implemented consistently with other providers. Verify that environment variable fallbacks and error messages meet your desired configuration standards. - Reason this comment was not posted:
Confidence changes required:20%<= threshold85%None
4. tests/test_auto_client.py:273
- Draft comment:
Tests for the Databricks provider are thorough, covering environment configuration, custom base_url handling, async client, and missing token/host errors. - Reason this comment was not posted:
Confidence changes required:0%<= threshold85%None
5. docs/integrations/databricks.md:15
- Draft comment:
Typo detected: The command on line 15 begins with "uv pip install instructor openai". Verify if "uv" is intended; if not, consider removing it to use the standard "pip install" command. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 85% "uv" is a legitimate Python package manager tool (created by Astral, the same team behind ruff). The author intentionally changed the installation command to use "uv pip install" instead of just "pip install". This is not a typo - it's a deliberate choice to use the uv tool. The comment is incorrectly identifying this as a typo when it's actually an intentional change. The comment also asks to "verify" which violates the rule about not asking the PR author to confirm their intention. Could "uv" be a typo that the author accidentally introduced? Maybe they meant to type something else? However, "uv pip install" is a valid and increasingly common command pattern in Python projects. While it's theoretically possible this is a typo, "uv pip install" is a well-known command pattern for the uv package manager. The fact that the author also added "openai" to the dependencies in the same change suggests this was a deliberate update to the installation instructions. Additionally, the comment asks to "verify" which violates the rules about not asking the author to confirm intentions. This comment should be deleted. It incorrectly identifies an intentional change (using the uv package manager) as a typo, and it asks the author to "verify" their intention, which violates the review rules.
6. instructor/auto_client.py:356
- Draft comment:
There's a duplicate '# type: ignore[attr-defined]' comment in the import statement. Consider removing the extra comment for cleanliness. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_zgeaksQcuGte8JXk
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add Databricks provider support
Describe your changes
This PR introduces full support for Databricks as a provider in
instructor.from_provider. It enables seamless integration with Databricks models by:DATABRICKS_TOKEN,DATABRICKS_HOST, etc.) or direct arguments./serving-endpoints.openai.OpenAIoropenai.AsyncOpenAIfor client functionality.This allows users to initialize Databricks clients using
instructor.from_provider("databricks/...")with minimal configuration.Issue ticket number and link
Checklist before requesting a review
Slack Thread
Important
Adds Databricks provider support to
instructor.from_provider, including environment-based configuration, URL normalization, and OpenAI client delegation.instructor.from_providerinauto_client.py, resolving API keys and host URLs from environment variables or arguments./serving-endpoints.openai.OpenAIoropenai.AsyncOpenAI.instructor.from_provider("databricks/...").databricks.mdwith setup instructions and usage examples.test_auto_client.pyfor environment configuration, custom base URL, async client, and error handling for missing token or host.This description was created by
for 8070043. You can customize this summary. It will automatically update as commits are pushed.