doc(openrouter): use explicit async_client=False#1847
Merged
jxnl merged 1 commit into567-labs:mainfrom Oct 13, 2025
Merged
Conversation
I have an issue where the default `instructor.from_provider` is inferred by Pyright to be `AsyncInstructor`, the issue is fixed once I explicitly declare `async_client=False`.
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 1305fdc in 46 seconds. Click for details.
- Reviewed
36lines of code in1files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/integrations/openrouter.md:37
- Draft comment:
Good: Explicitly setting async_client=False clarifies sync usage and fixes Pyright type inference issues. - Reason this comment was not posted:
Confidence changes required:0%<= threshold85%None
2. docs/integrations/openrouter.md:114
- Draft comment:
Explicit async_client=False improves clarity in nested object examples; looks consistent. - Reason this comment was not posted:
Confidence changes required:0%<= threshold85%None
3. docs/integrations/openrouter.md:163
- Draft comment:
Setting async_client=False here ensures structured outputs use the synchronous client as intended. - Reason this comment was not posted:
Confidence changes required:0%<= threshold85%None
4. docs/integrations/openrouter.md:212
- Draft comment:
Explicit async_client=False is now set in the JSON mode example, which aids in type clarity. - Reason this comment was not posted:
Confidence changes required:0%<= threshold85%None
5. docs/integrations/openrouter.md:252
- Draft comment:
Consider adding explicit async_client=False to the streaming example for consistency and to avoid similar type inference issues. - Reason this comment was not posted:
Confidence changes required:0%<= threshold85%None
Workflow ID: wflow_gHLr80J2KBiyxwIc
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have an issue where the default
instructor.from_provideris inferred by Pyright to beAsyncInstructor:the issue is fixed once I explicitly declare
async_client=False.Important
Explicitly set
async_client=Falseinopenrouter.mdto fix type inference issues in documentation examples.openrouter.md, explicitly setasync_client=Falsein four code examples to ensure correct type inference by Pyright.This description was created by
for 1305fdc. You can customize this summary. It will automatically update as commits are pushed.