Skip to content

update cohere text models.#1840

Merged
jxnl merged 2 commits into567-labs:mainfrom
phlogisticfugu:feature/fix-cohere-model-in-auto-client
Oct 8, 2025
Merged

update cohere text models.#1840
jxnl merged 2 commits into567-labs:mainfrom
phlogisticfugu:feature/fix-cohere-model-in-auto-client

Conversation

@phlogisticfugu
Copy link
Copy Markdown

@phlogisticfugu phlogisticfugu commented Oct 7, 2025

fix: cohere command-r-plus model is deprecated - causing tests to break

  • update the models to include the latest models from cohere. Keep deprecated models for the moment.
  • update tests and example code appropriately to use the latest command-a-reasoning-08-2025

Important

Update Cohere model to command-a-reasoning-08-2025 across documentation, examples, and tests, while retaining deprecated models for compatibility.

  • Model Update:
    • Update Cohere model from command-r-plus to command-a-reasoning-08-2025 in document_segmentation.md, cohere.md, and cohere.py.
    • Update from_provider() in auto_client.py to include command-a-reasoning-08-2025.
    • Add command-a-reasoning-08-2025 to KnownModelName in models.py.
  • Tests:
    • Update tests in test_json_schema.py and test_new_client.py to use command-a-reasoning-08-2025.
    • Modify test_auto_client.py to include command-a-reasoning-08-2025 in the list of providers to test.
  • Misc:
    • Keep deprecated command-r-plus model in models.py for backward compatibility.

This description was created by Ellipsis for 7eb2b69. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to 7eb2b69 in 1 minute and 55 seconds. Click for details.
  • Reviewed 207 lines of code in 8 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. instructor/models.py:25
  • Draft comment:
    Duplicate model entry: 'cohere/command-r7b-12-2024' appears twice. Consider removing the duplicate to avoid ambiguity.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_rUMyeBLRlrNtm8AV

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Comment thread tests/test_auto_client.py Outdated
@jxnl jxnl merged commit 27d8f9f into 567-labs:main Oct 8, 2025
3 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants