also add pop thinking_config to handle_genai_tools#1834
Merged
jxnl merged 1 commit into567-labs:mainfrom Oct 2, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to e72ac07 in 47 seconds. Click for details.
- Reviewed
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. instructor/providers/gemini/utils.py:897
- Draft comment:
Good fix: popping 'thinking_config' in handle_genai_tools now aligns with its removal in handle_genai_structured_outputs. This prevents unintended propagation. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold85%This comment is purely informative, acknowledging a good fix without providing any actionable feedback or suggestions. It doesn't align with the rules for useful comments.
Workflow ID: wflow_RGf3RWLVocxB9Qaw
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds to #1751 to put the fix also in
handle_genai_toolsfunction (now was only inhandle_genai_structured_outputs)Important
Remove
thinking_configfromnew_kwargsinhandle_genai_toolsto matchhandle_genai_structured_outputs.handle_genai_tools, removethinking_configfromnew_kwargsto match behavior inhandle_genai_structured_outputs.This description was created by
for e72ac07. You can customize this summary. It will automatically update as commits are pushed.