Skip to content

also add pop thinking_config to handle_genai_tools#1834

Merged
jxnl merged 1 commit into567-labs:mainfrom
oegedijk:main
Oct 2, 2025
Merged

also add pop thinking_config to handle_genai_tools#1834
jxnl merged 1 commit into567-labs:mainfrom
oegedijk:main

Conversation

@oegedijk
Copy link
Copy Markdown
Contributor

@oegedijk oegedijk commented Oct 2, 2025

adds to #1751 to put the fix also in handle_genai_tools function (now was only in handle_genai_structured_outputs)


Important

Remove thinking_config from new_kwargs in handle_genai_tools to match handle_genai_structured_outputs.

  • Behavior:
    • In handle_genai_tools, remove thinking_config from new_kwargs to match behavior in handle_genai_structured_outputs.

This description was created by Ellipsis for e72ac07. You can customize this summary. It will automatically update as commits are pushed.

@oegedijk oegedijk changed the title also add pop thinking_config to gemini tools helper also add pop thinking_config to handle_genai_tools Oct 2, 2025
Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to e72ac07 in 47 seconds. Click for details.
  • Reviewed 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. instructor/providers/gemini/utils.py:897
  • Draft comment:
    Good fix: popping 'thinking_config' in handle_genai_tools now aligns with its removal in handle_genai_structured_outputs. This prevents unintended propagation.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 85% This comment is purely informative, acknowledging a good fix without providing any actionable feedback or suggestions. It doesn't align with the rules for useful comments.

Workflow ID: wflow_RGf3RWLVocxB9Qaw

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@jxnl jxnl merged commit fed1d2c into 567-labs:main Oct 2, 2025
4 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants