Skip to content

fix(openai): reask functionality broken in JSON mode since v1.9.0 #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jxnl merged 3 commits into from
Sep 5, 2025
Merged

fix(openai): reask functionality broken in JSON mode since v1.9.0 #1793

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6a47d9
fix(openai): reask functionality in json mode
pnkvalavala Aug 29, 2025
68ad208
Merge branch 'main' into fix/openai-json-mode-retry-on-parse-error
jxnl Sep 4, 2025
541aa1c
Merge branch 'main' into fix/openai-json-mode-retry-on-parse-error
jxnl Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions instructor/processing/function_calls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,7 @@ def _validate_model_from_json(
raise ValueError(f"Failed to parse JSON: {e}") from e
except Exception as e:
logger.debug(f"Model validation error: {e}")
# Re-raise with more context
from ..core.exceptions import ValidationError as InstructorValidationError

raise InstructorValidationError(
f"Failed to validate model {cls.__name__}: {str(e)}"
) from e
raise


class OpenAISchema(BaseModel):
Expand Down