Skip to content

Conversation

@tsahee
Copy link
Contributor

@tsahee tsahee commented Aug 25, 2020

kmap_atomic is the recommended API, and it is much faster then kmap.

In my test, using kmap_atomic made memory dumps with LiME faster by an order of magnitude. I don't know what was the original reasoning for using kmap. I only put here a test for kernel version 2.6.37, but if you think we need to add some other compile or run time choice between kmap_atomic and kmap, I'd be happy to adjust.

Thank you!
Tsahi.

kmap_atomic is the recommended API, and it is much faster then kmap
@kd8bny
Copy link
Collaborator

kd8bny commented Aug 25, 2020

Cool Ill pull this in to test out !

@tsahee
Copy link
Contributor Author

tsahee commented Jan 11, 2021

@kd8bny did you get a chance to look at it?

@kd8bny
Copy link
Collaborator

kd8bny commented Jan 15, 2021

I have not and I really need to.
My apologies for falling behind on this, Im going to merge and test with the 5.10 fixes

@kd8bny kd8bny self-requested a review January 15, 2021 02:00
@kd8bny kd8bny self-assigned this Jan 15, 2021
@kd8bny kd8bny added this to the v1.10 milestone Jan 31, 2021
@kd8bny kd8bny merged commit e261550 into 504ensicsLabs:master Mar 21, 2021
@qodroi
Copy link

qodroi commented Apr 19, 2023

kmap_atomic caused my kernel to issue a bug - scheduling while atomic, with a message that preemption was disabled somewhere in the code. See what you can do about that, maybe revert to the original one? I'll see if I can find a solution without using the original kmap instead, due to performance issues, by your words.

Edit: See #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants