test: add msg and refresh for coverage test#3413
Draft
vagetablechicken wants to merge 10 commits intomainfrom
Draft
test: add msg and refresh for coverage test#3413vagetablechicken wants to merge 10 commits intomainfrom
vagetablechicken wants to merge 10 commits intomainfrom
Conversation
github-actions
bot
added
the
storage-engine
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3413 +/- ##
============================================
+ Coverage 75.33% 75.34% +0.01%
Complexity 414 414
============================================
Files 707 707
Lines 128428 128442 +14
Branches 1191 1191
============================================
+ Hits 96751 96775 +24
+ Misses 31436 31426 -10
Partials 241 241 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Contributor
SDK Test Report 98 files ±0 98 suites ±0 1m 58s ⏱️ -29s Results for commit 4159695. ± Comparison against base commit 1b8d596. This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/cmd/sql_cmd_test.cc
Outdated
| ASSERT_TRUE(cs->GetNsClient()->DropTable("test2", "trans", msg)) << msg; | ||
| ASSERT_TRUE(sr->RefreshCatalog()); // avoid cache in sdk | ||
| // helpful for debug | ||
| // TODO if refresh is not good, sleep more |
Contributor
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
| if (IsClusterMode()) { | ||
| if (RefreshSingleTable(request->tid())) { | ||
| PDLOG(INFO, "refresh success. tid %u", request->tid()); | ||
| if(request->has_tid()) { |
Contributor
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Missing space before ( in if( [whitespace/parens] [5]
| HandleSQL("use test2;"); | ||
| HandleSQL(create_sql); | ||
| sleep(5); | ||
| // TODO if refresh is not good, sleep more |
Contributor
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
src/tablet/tablet_impl.cc
Outdated
| const std::string& db_name = sp_info.db_name(); | ||
| const std::string& sp_name = sp_info.sp_name(); | ||
| const std::string& sql = sp_info.sql(); | ||
| LOG(INFO) << "create procedure rpc in " << endpoint_; // no get size func << " with sp cache " << sp_cache_-> |
Contributor
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
At least two spaces is best between code and comments [whitespace/comments] [2]
| response->set_code(::openmldb::base::ReturnCode::kOk); | ||
| response->set_msg("ok"); | ||
| LOG(INFO) << "create procedure success! sp_name: " << sp_name << ", db: " << db_name << ", sql: " << sql; | ||
| LOG(INFO) << "create procedure success! sp_name: " << sp_name << ", db: " << db_name << ", sql: " << sql << " on " << endpoint_; |
Contributor
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
Collaborator
Author
| response->set_msg("store procedure already exists"); | ||
| PDLOG(WARNING, "store procedure[%s] already exists in db[%s]", sp_name.c_str(), db_name.c_str()); | ||
| // print endpoint for ut debug | ||
| PDLOG(WARNING, "store procedure[%s] already exists in db[%s] on %s", sp_name.c_str(), db_name.c_str(), endpoint_.c_str()); |
Contributor
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
| response->set_code(::openmldb::base::ReturnCode::kOk); | ||
| response->set_msg("ok"); | ||
| PDLOG(INFO, "drop procedure success. db_name[%s] sp_name[%s]", db_name.c_str(), sp_name.c_str()); | ||
| PDLOG(INFO, "drop procedure success. db_name[%s] sp_name[%s] on %s", db_name.c_str(), sp_name.c_str(), endpoint_.c_str()); |
Contributor
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.