refactor: Move Location header logic to make_item_response#328
Merged
Conversation
itajaja
reviewed
Apr 3, 2020
| if location is not None: | ||
| response.headers["Location"] = location | ||
| return response | ||
| return self.make_item_response(item, 201) |
Member
There was a problem hiding this comment.
you want to amend the doc of this method
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
@itajaja does that answer the question, or am i missing something here?
itajaja
reviewed
Apr 3, 2020
Member
itajaja
left a comment
itajaja
left a comment
There was a problem hiding this comment.
I guess this makes sense after all
itajaja
approved these changes
Apr 8, 2020
| if location is not None: | ||
| response.headers["Location"] = location | ||
| return response | ||
| return self.make_item_response(item, 201) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.