fix: Increase rate-limit factor for Next.js app router#973
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
franky47
changed the title
commit: |
This tests how the throttled queue alleviates browsers rate-limiting calls to the History API for URL updates. Updates to a counter are made every 20ms for one minute, and the test keeps count of the result for each URL update (the resolved Promise from the state updater function). Note: updates are not made using the internal state of useQueryState, as it's data-racing against the URL. Instead, we keep a steady increasing count and only render the current URL value for progress.
franky47
force-pushed
the
test/rate-limits
branch
from
c23038f to
814eca7
Compare
|
🎉 This PR is included in version 2.4.2-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tests how the throttled queue alleviates browsers rate-limiting calls to the History API for URL updates.
Updates to a counter are made every 20ms for one minute, and the test keeps count of the result for each URL update (the resolved Promise from the state updater function).
Note: updates are not made using the internal state of useQueryState, as it's data-racing against the URL. Instead, we keep a steady increasing count and only render the current URL value for progress.
Note: as these tests are long-running and browser-dependent, they don't have an associated Cypress fixture.
It allowed detecting that a rate-limit factor of 3 is needed in the Next.js app router, which calls the History API on top of our own updates (so we have 3 calls per update for some reason).
See #960 (comment)