Upgrade Rmagick to 4.3.0 #3323
Closed
Upgrade Rmagick to 4.3.0 #3323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I upgraded to Fedora 38 and I found I can't run porta anymore. The cause is we are using rmagick 2.15.4 which requires ImageMagick 6 and doesn't support ImageMagick 7. But Fedora 38 only provides ImageMagick 7, version 6 is not available.
I had to upgrade rmagick to > 4.1 where support for ImageMagick 7 was added. In my tests, this doesn't seem to cause any issue. Why were we stuck on rmagick 2.x?
I need this to get merged because otherwise I'll have to manually update the Gemfile in all my branches but never commit it, and that's very inconvenient.
This upgrade shouldn't affect others because Rmagick 4 still supports ImageMagick 6. But I'd like you to test this and verify it works fine on Mac and older Fedora releases.