Skip to content

refine upload-artifact and fix version#3735

Merged
2dust merged 4 commits intomasterfrom
unknown repository
Oct 22, 2024
Merged

refine upload-artifact and fix version#3735
2dust merged 4 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 22, 2024

优化aftifact上传分类
修复api兼容

@ghost ghost changed the title refine upload-artifact and fix api version refine upload-artifact and fix version Oct 22, 2024
@codewithtamim
Copy link
Copy Markdown
Contributor

Hello dear friend, wasn't itOh, I posted the latest version. correct with these settings you changed?! Because, for example, API 35 is the latest version. @codewithtamim

Bro, the Android API in your PR refers to the minimum SDK version. You changed it to 35, which is wrong—it will only run on devices with API 35 or higher. It should be set to 21 (Android 5), which was the correct minimum SDK before.

@2dust 2dust merged commit d703582 into 2dust:master Oct 22, 2024
@ghost
Copy link
Copy Markdown

ghost commented Oct 22, 2024

Hello dear friend, wasn't itOh, I posted the latest version. correct with these settings you changed?! Because, for example, API 35 is the latest version. @codewithtamim

Bro, the Android API in your PR refers to the minimum SDK version. You changed it to 35, which is wrong—it will only run on devices with API 35 or higher. It should be set to 21 (Android 5), which was the correct minimum SDK before.

Bro,s latest stable version of Java is 21.(21 lts)
Does that mean version 17 is more compatible?!

Basic Configuration

Eclipse Temurin

steps:

uses: actions/checkout@v4
uses: actions/setup-java@v4
with:
distribution: 'temurin' # See 'Supported distributions' for available options
java-version: '21'
run: java HelloWorldApp.java

https://github.com/marketplace/actions/setup-java-jdk

@codewithtamim @any116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants