Skip to content

Conversation

@DHR60
Copy link
Contributor

@DHR60 DHR60 commented Sep 6, 2025

@2dust
Copy link
Owner

2dust commented Sep 7, 2025

你想把一些公用代码 放 ProfilesBaseViewModel 对吧?
建议不要这样做,直接实现 ProfilesSelectViewModel 就好了,功能不会太多,只需要简单的实现列表和过滤就好。
并且列的拖动,显示流量信息等功能都是不必要的,列表也不需要这么多。
还有可能这个 ProfilesSelectView 后面的操作模式还会变化;必要的冗余重复代码是可以接受的

@DHR60 DHR60 force-pushed the select_node_windows branch from 0085e0a to 7aa41cc Compare September 7, 2025 04:02
@DHR60 DHR60 force-pushed the select_node_windows branch from 7aa41cc to f11b46e Compare September 7, 2025 04:03
@DHR60
Copy link
Contributor Author

DHR60 commented Sep 7, 2025

done

@DHR60
Copy link
Contributor Author

DHR60 commented Sep 7, 2025

拖动好像没实现
显示流量信息还有其他信息,AppManager.Instance.ProfileItems 返回的好像就是 ProfileItemModel,就 xaml 多几行表头,应该影响不大吧

@DHR60 DHR60 marked this pull request as ready for review September 7, 2025 07:53

#endregion WhenAnyValue && ReactiveCommand

#region AppEvents
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppEvents 是用来接收更新订阅等等的更新的,这里不需要的。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我记得我删了来着,好像和那个commit一块drop掉了


#region Actions

public void UpdateStatistics(ServerSpeedItem update)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不需要,并且UI 也移除吧。


//await ConfigHandler.SetDefaultServer(_config, lstModel);

var lstServerStat = (_config.GuiItem.EnableStatistics ? StatisticsManager.Instance.ServerStat : null) ?? [];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

流量和速度可以不要

@DHR60
Copy link
Contributor Author

DHR60 commented Sep 7, 2025

done

@2dust 2dust merged commit 04195c2 into 2dust:master Sep 7, 2025
@DHR60 DHR60 deleted the select_node_windows branch September 7, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants