Open
Conversation
b-rowan
requested changes
Apr 10, 2026
Member
b-rowan
left a comment
There was a problem hiding this comment.
Looks solid. So much boilerplate when creating a new type, might be worth trying to make a script to reduce that, but we don't do it that often so I guess its not a big deal.
Collaborator
Author
|
should be close now, some shameful 1 start indexing...so working around that makes it a bit messy but a good start. tested on a machine seems ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
This adds first-class support for Auradine miners in
asic-rs, including discovery, data collection, and control operations.Notes
Validation
cargo checkcargo test -p asic-rs-firmwares-auradinecargo test -p asic-rs-makes-auradine