Editor mode #56

fordelord · 2022-12-08T05:40:03Z

No description provided.

netlify · 2022-12-08T05:40:10Z

✅ Deploy Preview for alex-code-blog ready!

Name	Link
🔨 Latest commit	`732869a`
🔍 Latest deploy log	https://app.netlify.com/sites/alex-code-blog/deploys/6463376a6da23100073d9c04
😎 Deploy Preview	https://deploy-preview-56--alex-code-blog.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

…CodeBlog into editor-mode-code-

1alexvash · 2023-01-09T14:34:28Z

helpers/markdownDocumentsReader.ts

+  const docs = slugs
+    .map((slug) => getPostDocumentBySlug(slug))
+    .filter((post: PostDocument) => {
+      if (isPostADraft(post) || isPostInTheFuture(post)) {


We repeat those lines of code a lot

isPostADraft(post) || isPostInTheFuture(post)

Create a combined helper isUpcomingPost

1alexvash · 2023-03-04T07:49:38Z

components/Intro.tsx

+  const [isFirstRender, setIsFirstRender] = useState(true);
+
+  const handleClick = () => {
+    if (admin === true) {


Suggested change

if (admin === true) {

if (admin) {

It's a same thing

1alexvash · 2023-03-04T07:50:06Z

components/Intro.tsx

+      imageWrapper?.setAttribute("admin", "");
+      editIcon?.setAttribute("admin", "");
+      setIsFirstRender(false);
+    }


Add a break line down below, for the consistency

1alexvash · 2023-03-04T07:50:22Z

components/Intro.tsx

+      editIcon?.setAttribute("admin", "");
+      setIsFirstRender(false);
+    }
+    if (!admin && isFirstRender === false) {


Suggested change

if (!admin && isFirstRender === false) {

if (!admin && !isFirstRender) {

Use the same syntax for both of them

1alexvash · 2023-03-04T07:51:13Z

components/Intro.tsx

+  }, [admin, isFirstRender]);
+
+  return (
+    <section className="intro-section">


We can do MUI in here

#82 - refactor of MUI component. I think it will be easier for you to check this refactor if it will be like another PR.

1alexvash · 2023-03-04T07:51:26Z

components/Post/LatestPosts.tsx

-                    ? "grayscale(50%)"
-                    : "none",
-
+                filter: isUpcomingPost(post) ? "grayscale(50%)" : "none",


Love this utility function

1alexvash · 2023-03-04T07:54:04Z

helpers/markdownDocumentsReader.ts

+
+export function getUpcomingPosts(): PostDocumentWithoutContent[] {
+  const slugs = fs.readdirSync(documentsDirectory);
+  const docs = slugs
+    .map((slug) => getPostDocumentBySlug(slug))
+    .filter((post: PostDocument) => isUpcomingPost(post))
+    .sort((post1, post2) => (post1.date > post2.date ? -1 : 1))
+    .map((post) => {
+      const { content, ...postWithoutContent } = post;
+      return postWithoutContent;
+    });
+
+  return JSONSerialize(docs);
+}


Tina CMS is fetching posts somewhat differently, so it might cause some merge conflicts

I might merge Tina first, and only then you're going to update this utility method

1alexvash · 2023-03-04T07:55:26Z

pages/_app.tsx

+import AdminProvider from "@/components/AdminProvider";
 import ThemeProvider from "@/components/MUI/ThemeProvider";


Suggested change

import AdminProvider from "@/components/AdminProvider";

import ThemeProvider from "@/components/MUI/ThemeProvider";

import AdminProvider from "components/AdminProvider";

import ThemeProvider from "components/MUI/ThemeProvider";

It's a same thing, is there any reason we're using @ symbol?

1alexvash · 2023-03-04T07:55:53Z

pages/index.tsx

      <section className="simple-section">
        <div className="container">
+          {admin && <UpcomingPosts posts={upcomingPosts} />}
          {/* TODO: Implement tags count for the admin user */}


I think you've done this TODO item

1alexvash · 2023-03-04T07:57:16Z

pages/api/getUpcomingPosts.ts

+  const posts = getUpcomingPosts();
+
+  res.status(200).json(posts);
+}


Tina GraphQL query might look a bit differently, so just heads up

Ok, waiting for merge of Tina and after will be fixing that

1alexvash · 2023-03-04T07:57:57Z

styles/main.scss

 }

-.intro-avatar .image img {
+.intro-avatar .image-avatar:after {


We won't need it with MUI, right?

yea. I add the PR with refactor of Intro component to mui. I think it will be easier for you to check this refactor if it will be like another PR. #82

Refactor intro section component to mui

fordelord changed the title ~~first-commit~~ Editor-mode-code Dec 8, 2022

fordelord added 23 commits December 8, 2022 07:41

first-commit

bee43e4

little-fix

d066a4f

fix-type-temporarily

678c67c

test-with-post

774f106

Merge branch 'master' into editor-mode-code-

b424d2f

remove-test

deffb4c

improvment-by-cookie-&-result-version

1a17ac8

Merge branch 'master' into editor-mode-code-

7b5f56f

remake-index-file-for-netlify

7d3148c

Merge branch 'editor-mode-code-' of https://github.com/1alexvash/Alex…

9955712

…CodeBlog into editor-mode-code-

Update yarn.lock

20e3520

remake-functional-to-localStorage

e29a1e1

add-breakpoint

6137239

remove-useful-npm

ab448ba

change-name-slice

18672bf

Merge branch 'editor-mode-code-' of https://github.com/1alexvash/Alex…

a19b21d

…CodeBlog into editor-mode-code-

remove-useful-npm

6475744

Update yarn.lock

a5e63d1

Update yarn.lock

08d4a62

change-name

b1a39f9

Merge branch 'editor-mode-code-' of https://github.com/1alexvash/Alex…

e72cf4c

…CodeBlog into editor-mode-code-

change-double-click-event

2033da2

remove-useless-fragment

81cbccb

1alexvash marked this pull request as draft December 23, 2022 22:39

1alexvash changed the title ~~Editor-mode-code~~ Editor-mode-code | [Paused] Dec 23, 2022

1alexvash changed the title ~~Editor-mode-code | [Paused]~~ Editor mode Jan 9, 2023

1alexvash marked this pull request as ready for review January 9, 2023 14:33

1alexvash reviewed Jan 9, 2023

View reviewed changes

fordelord added 2 commits January 16, 2023 16:54

change-test-condition

5bb938f

remove-magic-number

2ee9b31

1alexvash marked this pull request as draft January 23, 2023 07:06

fordelord added 2 commits January 30, 2023 23:24

implement-feature-of-count-tags-in-admin

1b01b4e

change-import-admin-state

f65560a

fordelord marked this pull request as ready for review January 30, 2023 21:31

change-number-to-square-brackets

4649e63

fordelord force-pushed the editor-mode-code- branch from 5e147db to 4649e63 Compare February 27, 2023 10:37

fordelord and others added 6 commits February 27, 2023 12:43

Merge branch 'master' into editor-mode-code-

fda802a

fix-an-arror-after-merge

4580d44

refactor-upcomingPost-component-to-MUI

55f2712

remake-postImg-after-style

60ce23d

merge-two-style-into-one

f0b10b5

Resolve merge conflicts

e020a28

1alexvash requested changes Mar 4, 2023

View reviewed changes

fordelord added 3 commits March 5, 2023 17:34

changes-by-code-review

69fbaf9

refactor-intro-component-to-mui

b6f0958

remove-useless-className

122b503

fordelord marked this pull request as draft March 6, 2023 09:08

fordelord added 2 commits March 6, 2023 11:17

change-color-name-to-correct

4977a57

changes-by-code-review

942726b

fordelord marked this pull request as ready for review March 6, 2023 09:25

fordelord added 3 commits March 6, 2023 11:31

change-name-of-variable-to-correct

52b6637

Merge branch 'master' into editor-mode-code-

1da996c

changes-by-prettier

e370af1

fordelord requested a review from 1alexvash March 13, 2023 19:29

fordelord added 2 commits March 16, 2023 16:43

Merge pull request #82 from 1alexvash/refactor-introSection-component

3903690

Refactor intro section component to mui

remove admin edit icon

732869a

ntorbinskiy closed this Jul 24, 2023

ntorbinskiy deleted the editor-mode-code- branch August 1, 2023 07:44

	if (!admin && isFirstRender === false) {
	if (!admin && !isFirstRender) {

		import AdminProvider from "@/components/AdminProvider";
		import ThemeProvider from "@/components/MUI/ThemeProvider";

Editor mode #56

Editor mode #56

Uh oh!

Conversation

fordelord commented Dec 8, 2022

Uh oh!

netlify bot commented Dec 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for alex-code-blog ready!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

netlify bot commented Dec 8, 2022 •

edited

Loading