Generated Typescript now uses null to represent unit types
#82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazgilebits
approved these changes
Mar 23, 2023
lazgilebits
left a comment
lazgilebits
left a comment
There was a problem hiding this comment.
Confirming all of the newly generated code is valid TypeScript 👍
Approved!
LuminaSapphira
approved these changes
Mar 23, 2023
Collaborator
|
LGTM! |
LuminaSapphira
pushed a commit
that referenced
this pull request
Apr 13, 2023
…to-null"" This reverts commit 08769e5.
LuminaSapphira
pushed a commit
that referenced
this pull request
Apr 13, 2023
Revert "Merge pull request #82 from 1Password/jane/undefined-to-null"
LuminaSapphira
pushed a commit
that referenced
this pull request
Apr 13, 2023
…to-null"" This reverts commit 08769e5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
()is represented asnullinstead ofundefined- this also applies to unit enum variants.Fixes #43.