Add API Credential logic to model conversions #290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Summary
The category comparison was failing to set the API Credential Category because in new item conversions whic hwere implemented with the migration to SDK we did not handle for this category as support here is not official. This type comparison issue prevented the credential field from being populated.
I have added a API Credential category and added it to the mapping helpers. I also moved the field setting logic for
credentialto the field switch case. E2E test has been added.🔗 Resolves:
Resolves: #287
✅ Checklist
🕵️ Review Notes &⚠️ Risks
The bug can reproduced manually using v3.0.0 by attempting to access the credential field in an API Credential Item. The value ends up being null as we never set the category on the item.