Fix empty string handling #282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Summary
When a field is set to "" in Terraform, the provider was converting it to null when reading back from the sdk, causing Terraform to report an inconsistency.
To fix
setStringValuePreservingEmptypreserves empty strings when they were explicitly set in the config, instead of converting them to null.🔗 Resolves:
Resolves: #223
Resolves: #215
Resolves: #185
✅ Checklist
🕵️ Review Notes &⚠️ Risks
For manual testing the item below covers the fields that many were running into when trying to set an empty string as a value. This should result in several inconsistent state warnings for the empty string field using most recent version of the provider. This fix in this issue allows us to pass these as empty strings.