feat: add last transfer heuristic for transactions which fail to parse #93
+131
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barskhianfannie
force-pushed
the
main
branch
2 times, most recently
from
85599bb to
502eade
Compare
barskhianfannie
force-pushed
the
main
branch
from
502eade to
20439b5
Compare
barskhianfannie
changed the title
barskhianfannie
changed the title
hzhu
reviewed
Nov 30, 2025
src/tests/index.test.ts
Outdated
| address: "0x4200000000000000000000000000000000000006", | ||
| }, | ||
| }); | ||
| }); |
Member
There was a problem hiding this comment.
Can you add a new line here? 🙏
Suggested change
| }); | |
| }); | |
hzhu
previously approved these changes
Nov 30, 2025
.env.example
Outdated
| ALCHEMY_API_KEY="your-alchemy-api-key-here" | ||
|
|
||
|
|
||
| # Required: QuickNode API keys for specific chain tests |
Member
There was a problem hiding this comment.
nit: proper casing for Quicknode.
Suggested change
| # Required: QuickNode API keys for specific chain tests | |
| # Required: Quicknode API keys for specific chain tests |
Member
|
Thanks for the PR! Appreciate the description, and tying the PR to an issue. |
barskhianfannie
changed the title
barskhianfannie
commented
Dec 3, 2025
Comment on lines
+67
to
+73
| // The Issue: FOR SETTLERINTENT TXNS only - The taker address passed into calculateNativeTransfer is not the actual takers address, causing nativeAmountToTaker to be 0 when it shouldn't be | ||
| // Potential Solution: we need to determine if the txn is a settlerIntent txn, if so we | ||
| // can determine the taker from the to address in the last trace call. | ||
| const actualTaker = trace.calls[trace.calls.length-1].to; | ||
| //Scans the execution trace for any internal ETH transfers to the taker's address | ||
| const nativeAmountToTaker = calculateNativeTransfer(trace, { | ||
| recipient: taker, | ||
| recipient: taker, // for Settler Intent txns we should use actualTaker |
Member
Author
There was a problem hiding this comment.
@duncancmt In order to solve the failing parse for this Optimism txn, I am thinking of using the solution outlined in the comments of this codeblock. Any feedback before I begin implementation on if this is a valid approach or not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The existing parser fails in two example swaps:
0x7eea91c5c715ef4bb1e39ddf4c7832113693e87c18392740353d5ae669406a46Etherscan0xdee6f4fea0250f297ed9663c4ca4479e8a253c62e16faa60759e25832cd1f34fOpScanResolves Issue #94
Solution
Adds fallback logic when primary parsing fails using a last transfer heuristic:
Changes
src/index.ts: Added fallback logic using last transfersrc/tests/index.test.ts: Added tests for the failing txnsTesting
Ensure all tests are passing locally.
Additional Changes
.env.exampleregarding the various enviornment variables needed to successfully run all tests.