This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Fix fillableTakerAssetAmount in order event subscription payload
#179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…setAmount` is sent over the wire as a stringified amount and never in scientific notation
Contributor
|
@fabio what do you think about implementing our own wrapper type around |
Contributor
Author
|
That is a great idea. I love it. I'll create an issue for doing this refactor and will tackle it in a subsequent PR. |
albrow
approved these changes
Jun 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #178
Add custom MarshalJSON method for OrderEvent so that
fillableTakerAssetAmountis sent over the wire as a stringified amount and never in scientific notation.