Skip to content

Conversation

@liuyueyangxmu
Copy link

@liuyueyangxmu liuyueyangxmu commented Nov 26, 2025

Description

remove repetitive word in comment

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@sonarqubecloud
Copy link

@liuyueyangxmu
Copy link
Author

@marcello33 @kamuikatsurgi Please review this pr when youn have time.

@liuyueyangxmu
Copy link
Author

I have added at least 2 reviewer or the whole pos-v1 team

@liuyueyangxmu
Copy link
Author

@marcello33 Thank you for your approval.

If there's anything need I to do, please feel free to let me know.

@liuyueyangxmu
Copy link
Author

It seems that the CI failure is unrelated to this change

Waiting for more block progress...
❌ Sync recovery test failed for after extreme network latency - insufficient progress or excessive milestone lag within 300s
❌ Extreme network latency recovery test failed

@marcello33 marcello33 requested a review from a team December 2, 2025 10:13
@marcello33
Copy link
Collaborator

It seems that the CI failure is unrelated to this change

Waiting for more block progress...
❌ Sync recovery test failed for after extreme network latency - insufficient progress or excessive milestone lag within 300s
❌ Extreme network latency recovery test failed

Yes, no worries, not related to your changes.
Waiting for another approval before merging, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants