Skip to content

cmd/geth: possible logging test line-count message mismatch #2275

@cccpgqa

Description

@cccpgqa

Overview of the problem

Ethereum go-ethereum recently fixed a small issue in cmd/geth/logging_test.go:
geth #35136

I checked Polygon Bor and found that cmd/geth/logging_test.go appears to still use the old argument order:

t.Errorf("format %v, want %d lines, have %d", format, len(haveLines), len(wantLines))

This seems to only affect the diagnostic output of the test failure message.
Could you confirm whether Bor also needs this change?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions