Skip to content

Conversation

@MR-SS
Copy link

@MR-SS MR-SS commented Feb 17, 2025

Hello,

First of all, thank you for the great tool you developed. In some of the applications I was testing, based on the basic usage you provided, I encountered the following error:

Failed to spawn: unable to find process with name 'com.target.application'

After searching through Frida commands and doing some research online, I came to this conclusion, and I thought it would be better to add it to your valuable repository.

@codara-ai-code-review
Copy link

Potential issues, bugs, and flaws that can introduce unwanted behavior.

  1. /README.md - The instructions provided for obtaining the PID of an application using adb shell ps | grep com.target.application might not yield the expected process in environments with multiple instances of the same application or when the application is not currently running. There is a risk of pulling in unintended processes or no results at all if not careful, leading to confusion for users.

Code suggestions and improvements for better exception handling, logic, standardization, and consistency.

  1. /README.md - To improve clarity and usability, suggest including a note on how to handle cases where multiple processes are returned from the grep command. Consider adding something like: "If multiple instances are running, identify the correct PID using additional context or filtering, such as using grep with more specific criteria (e.g., user or command line options)."
  2. /README.md - Standardize the frida command examples by using a placeholder that indicates user action or customization. For instance, use frida -U -p [PID] -l root_bypass.js instead of frida -U -p <PID> -l root_bypass.js to signify user input more clearly.

@0xCD4
Copy link
Owner

0xCD4 commented Feb 18, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants