Skip to content

Conversation

@hxkuc
Copy link

@hxkuc hxkuc commented Nov 1, 2018

No description provided.

@0x61726b
Copy link
Owner

0x61726b commented Nov 1, 2018

Hello, thanks for the PR.

Is there any specific reason for editing package.json just to change URLs and author? I can't accept the PR if it changes package.json like that.

@hxkuc
Copy link
Author

hxkuc commented Nov 1, 2018

sorry, I can't use github, this is my first fork, and i make my npm package electron-vue-windows, it's used your package, so i changed some places, i don't know how to do this

@hxkuc
Copy link
Author

hxkuc commented Nov 1, 2018

your package is very good, I'll revise it and submit it

@0x61726b
Copy link
Owner

0x61726b commented Nov 1, 2018

Thanks! You just need to edit back the package.json to the original and its good.

@hxkuc
Copy link
Author

hxkuc commented Nov 1, 2018

ok, i will do it tonight, I'm off duty now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants