Missing builtins (`bsearch` and more)

[thaliaarchi]

The following builtins defined in builtin.c are not supported by jaq:

• tonumber/1
• toboolean/1
• keys/1
• setpath/3
• delpaths/2
• type/1
• bsearch/2
• format/2
• get_search_list/1
• get_prog_origin/1
• get_jq_origin/1
• modulemeta/1
• input_filename/1 (support input_filename #144)
• input_line_number/1
• have_decnum/1
• have_literal_numbers/1

This list is probably not exhaustive. I noticed that jaq does not support bsearch, which is needed by wsjq and did a quick check of others that look to be missing which are implemented in the same place in jq.

Error: undefined filter
   ╭─[ws.jq]
   │
35 │   bsearch($offset) as $i |
   ┆   ───┬───                 
   ┆      │                    
   ┆      ╰───────────────────── undefined filter
───╯

[01mf02]

Hi @thaliaarchi, I'm sympathetic to making wsjq run with jaq, so I went ahead and implemented bsearch (#299). If you're happy with the implementation, just comment and I'll merge it.

As for the other filters, there seems to be a misunderstanding: Consider the following line in builtin.c from jq:

CFUNC(f_keys, "keys", 1),

You seem to have inferred that this means that jq defines keys/1; however, there is no keys/1:

$ jq -n 'keys(1)'
jq: error: keys/1 is not defined at <top-level>, line 1, column 1:
    keys(1)
    ^^^^
jq: 1 compile error

There is a keys/0, though. So I suppose that CFUNC(_, f, n+1) implies that f/n is defined.
You will thus find that many of these filters are actually available in jaq, even if not all of them.

My focus right now is mostly on getting jaq 3.0 with multi-format support ready, so I'll not go ahead and implement all missing filters myself, but I'll be happy to accept PRs for most of these filters.
If some of these missing filters are crucial for a particular, publicly available jq program (e.g. wsjq :)), then I might still be motivated to divert myself for a moment by implementing it myself. :)

[thaliaarchi]

Thank you for implementing bsearch and looking into the others. wsjq now works!

As for my little survey of those builtins, if it's not useful, feel free to close this now. Or, I could re-review the list with your corrections, if you'd like to track it.

[01mf02]

Great to hear that wsjq now works with jaq!

I'll close this issue now, because I currently do not have the intention to implement any of the missing filters from the list.