Skip to content

STY: enforce RUF031 in pre-commit#5394

Open
neutrinoceros wants to merge 1 commit intoyt-project:mainfrom
neutrinoceros:sty/ruf031
Open

STY: enforce RUF031 in pre-commit#5394
neutrinoceros wants to merge 1 commit intoyt-project:mainfrom
neutrinoceros:sty/ruf031

Conversation

@neutrinoceros
Copy link
Member

A bit of background: this linting rule was implemented in ruff specifically because we requested it for usage in yt. I originally selected the rule at the global level, knowning it was still in "preview" (i.e. unstable) mode, which had no effect beyond triggering a warning, because I was expecting it would be stabilized soon after. This hasn't happened (yet), presumably for a lack of feedback.
Because the rule was tailored for an idiom very commonly seen in yt, I figure it would make sense that we beta-test the unstable (but so far, absolutely correct) implementation so we can later confidently ask it be marked stable without change.

refs:

@neutrinoceros neutrinoceros added infrastructure Related to CI, versioning, websites, organizational issues, etc code style Related to linting tools labels Mar 8, 2026
@neutrinoceros
Copy link
Member Author

actually there might be some good reason (other than lack of feedback) for this rule to not be marked as stable yet:

(this shouldn't affect us though)

@matthewturk
Copy link
Member

Thanks for doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code style Related to linting tools infrastructure Related to CI, versioning, websites, organizational issues, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants