Support (N, M, L) per-dimension zones in octree containers#5391
Open
cphyc wants to merge 2 commits intoyt-project:mainfrom
Open
Support (N, M, L) per-dimension zones in octree containers#5391cphyc wants to merge 2 commits intoyt-project:mainfrom
cphyc wants to merge 2 commits intoyt-project:mainfrom
Conversation
Draft
cphyc
force-pushed
the
feature/support-non-cubic-zones
branch
from
cf2d51e to
d126ef5
Compare
Blocks may contain more than 256 cells - prevent overflow of the uint8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Currently, yt only supports cubic "zones" for octrees: this means that octree datasets can only contain
(N, N, N)cells in each leaf oct, whereNis controlled with the dataset parameternum_zones.This PR allows passing a tuple of values of
num_zones, increasing flexibility in support of #5390. In practice, this allows having an octree of blocks, where each block contains(N, M, L)cells.This PR should leave the RAMSES, Art and Stream frontends behaviour unchanged.
PR Checklist