perf: vectorize generalized Pauli-Z construction#1893
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
happykawayigt
marked this pull request as ready for review
July 25, 2026 17:03
Owner
|
Thanks for this, and welcome to toqito! I verified the vectorized output is bit-for-bit identical to the previous implementation across a wide range of dimensions, and the existing tests pass. Clean change, and good call dropping the now-unused cmath import. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Vectorizes the roots-of-unity construction in
gen_pauli_zwith NumPy operations while preserving the function's signature and bit-for-bit output. Addresses #1887.Changes
np.exp(np.arange(dim) * c_var).Benchmark
Measured on Windows, Python 3.12, NumPy 2.5.1:
Validation
python -m pytest toqito/matrices/tests/test_gen_pauli_z.py -q(19 passed)python -m ruff check toqito/matrices/gen_pauli_z.pypython -m ruff format --check toqito/matrices/gen_pauli_z.pyChecklist
rufffor errors related to code style and formatting.pytest.