docs: use actual lowercase parameter names in error messages (#1885)#1891
Open
marceli1404 wants to merge 1 commit into
Open
docs: use actual lowercase parameter names in error messages (#1885)#1891marceli1404 wants to merge 1 commit into
marceli1404 wants to merge 1 commit into
Conversation
Fixes vprusso#1885 Replace MATLAB/QETLAB-style uppercase parameter names (PHI, DIM, X) with the actual Python parameter names (phi, dim, input_mat) in user-facing ValueError messages so users can map the error to their code.
Owner
|
@marceli1404 your build is failing FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1885
Replace MATLAB/QETLAB-style uppercase parameter names with actual Python parameter names in user-facing error messages:
No tests assert on these exact strings, so no test updates were needed.