Merged
Conversation
ehelms
force-pushed
the
add-cname-support
branch
2 times, most recently
from
ed3ede4 to
640e718
Compare
Member
Author
|
Rebased |
ehelms
force-pushed
the
add-cname-support
branch
from
640e718 to
e3d2e24
Compare
ehelms
force-pushed
the
add-cname-support
branch
from
e3d2e24 to
841ee07
Compare
evgeni
reviewed
Mar 6, 2026
evgeni
reviewed
Mar 6, 2026
evgeni
reviewed
Mar 6, 2026
evgeni
reviewed
Mar 6, 2026
| -key "{{ certificates_ca_directory_keys }}/{{ certificates_hostname }}.key" | ||
| -subj "/CN={{ certificates_hostname }}" | ||
| -addext "subjectAltName = DNS:{{ certificates_hostname }}" | ||
| -addext "subjectAltName = DNS:{{ certificates_hostname }}{% for cname in certificates_cnames %},DNS:{{ cname }}{% endfor %}" |
Member
There was a problem hiding this comment.
quite unrelated to this particular PR, I realized we do not regenerate the cert if any of its properties change. should we?
evgeni
requested changes
Mar 6, 2026
Signed-off-by: Eric D. Helms <[email protected]>
ehelms
force-pushed
the
add-cname-support
branch
from
841ee07 to
96c1991
Compare
evgeni
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes #294
This aims to add cname support to the default set of certificates, which is functionality foreman-installer allowed.