Add support for authenticated registries#245
Conversation
2926317 to
ed0815f
Compare
cf006d9 to
24bbeef
Compare
24bbeef to
812ded7
Compare
ed5d92d to
b90a0a2
Compare
b90a0a2 to
728ce15
Compare
|
This has worked fine with #369, so I guess that my recommendation could be ammended if needed later. |
728ce15 to
bbb6195
Compare
bbb6195 to
edc5cb2
Compare
|
Thinking about this, how would it fit with future rootless containers which probably won't have access to the auth file? |
In that case, the authentication file would be located in a different location I think. Relative to the user's home for example. I am hesitant to optimize for that. |
|
|
||
| roles: | ||
| - role: pre_install | ||
| post_tasks: |
There was a problem hiding this comment.
tasks already runs after roles, so why using post_tasks here?
There was a problem hiding this comment.
Cause that ordering is not obvious, while I find post_tasks to be self-documenting in terms of order.
| --- | ||
| redis_container_image: quay.io/sclorg/redis-6-c9s | ||
| redis_container_tag: "latest" | ||
| redis_registry_auth_file: /etc/foreman/registry-auth.json |
There was a problem hiding this comment.
does it work if we set it to None here?
| redis_registry_auth_file: /etc/foreman/registry-auth.json | |
| redis_registry_auth_file: |
As we should try to keep the role free of Foreman specifics
There was a problem hiding this comment.
I suppose. This is foremanctl so it's kinda in the name? 😁
edc5cb2 to
d604d55
Compare
Signed-off-by: Eric D. Helms <ericdhelms@gmail.com>
d604d55 to
0cd5168
Compare
Enables foremanctl to authenticate with private registries by checking for auth files before attempting image pulls. Users can run
podman login <registry> --authfile=/etc/foreman/registry-auth.jsonand foremanctl will automatically use the credentials when available.