Refs #34758: Match rename of remote_execution::ssh to remote_executio…#759
Merged
ehelms merged 1 commit intotheforeman:developfrom Apr 21, 2022
Merged
Refs #34758: Match rename of remote_execution::ssh to remote_executio…#759ehelms merged 1 commit intotheforeman:developfrom
ehelms merged 1 commit intotheforeman:developfrom
Conversation
ekohl
requested changes
Apr 11, 2022
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I'd prefer if you all have the same timestamps so it's easy to correlate. The easiest way to achieve this is to call ./bin/create-migration with all scenarios it applies to.
Comment on lines
+2
to
+3
| answers['foreman_proxy::plugin::remote_execution::script'] = answers['foreman_proxy::plugin::remote_execution::ssh'] | ||
| answers.delete('foreman_proxy::plugin::remote_execution::ssh') |
Member
There was a problem hiding this comment.
Suggested change
| answers['foreman_proxy::plugin::remote_execution::script'] = answers['foreman_proxy::plugin::remote_execution::ssh'] | |
| answers.delete('foreman_proxy::plugin::remote_execution::ssh') | |
| answers['foreman_proxy::plugin::remote_execution::script'] = answers.delete('foreman_proxy::plugin::remote_execution::ssh') |
Contributor
|
Also inconsistent dashes vs underscores in migration file names? |
Member
|
Sadly that was already the case before and now we at least (try) to keep them consistent per scenario. In #736 I tried to align them but didn't get around to finishing it. |
Member
Author
|
[test foreman-installer] |
Member
Author
|
@evgeni This is also ready now |
evgeni
approved these changes
Apr 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n::script
See theforeman/puppet-foreman_proxy#734