Open
Conversation
This adds a workflow to check that PR titles and descriptions meet a bare minimum of criteria: - nonempty title - nonempty description - title at least 2 words - description at least 10 characters long
pavoljuhas
reviewed
Jan 21, 2026
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
Please see inline, looks like this can never trigger.
Since the workflow already executes for this PR, try to add a commit increasing minimum words to 100 and see if it fails as intended. After that revert the commit to restore the normal word count limit back.
| { | ||
| echo "Please fix the following problem(s) with this PR:" | ||
| printf -- ":x: %s\n" "${problems[@]}" | ||
| } >> "${GITHUB_STEP_SUMMARY}" |
Collaborator
There was a problem hiding this comment.
Please add exit 1 or such to indicate check failure.
| # this text easier for people to find in the workflow results. | ||
| - name: Report outcome | ||
| run: | | ||
| if [[ "${result}" == "error" ]]; then |
Collaborator
There was a problem hiding this comment.
The ${result} parameter is unset so the block will never run.
Consider replacing with GHA's if: failure()
pavoljuhas
reviewed
Jan 21, 2026
| fi | ||
|
|
||
| if [[ ${#problems[@]} -gt 0 ]]; then | ||
| # shellcheck disable=SC2034 |
Collaborator
There was a problem hiding this comment.
Is this code ever visited by shellcheck? If not, please remove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a workflow to check that PR titles and descriptions meet a bare minimum of criteria: