Increase number of retries for Pubchem test even more#1286
Merged
Conversation
It is still failing, but I found a way to reproduce it locally. Using that testing, I found that this combination allows it to get through even very many server busy errors.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the retry count from 4 to 8 for the test_geometry_from_pubchem_live_api test to better handle flakiness. A review comment points out a discrepancy between the code and the PR description, noting that the delay parameter was not increased as intended.
mhucka
changed the title
pavoljuhas
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pubchem live api test in
src/openfermion/chem/pubchem_test.pywould still fail too frequently in CI. After finally finding a way to reproduce it locally, I tweaked the retries parameter for pytest so that it succeeds locally. That's not a guarantee it won't fail again in CI (because it depends on how busy the Pubchem server is at a given time), but the number of retries and delay now are so high that I haven't been able to get it to fail due to retries.Approach to seeing retries in local testing:
The number of parallel threads in
-ndoes not have to be 4 exactly, but lower numbers are less likely to trigger retries. The repeat count of 30 also can be a little bit lower, but at lower values, there's a higher chance that all tests will pass without retries (probably depending on the server load at the time).