Skip to content

Increase the delay between PubChem retries#1284

Merged
mhucka merged 3 commits into
quantumlib:mainfrom
mhucka:increase-pubchem-delay
Apr 24, 2026
Merged

Increase the delay between PubChem retries#1284
mhucka merged 3 commits into
quantumlib:mainfrom
mhucka:increase-pubchem-delay

Conversation

@mhucka

@mhucka mhucka commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

The live API test still fails in CI. It ends up failing 4 times in a row:

test_geometry_from_pubchem_live_api failed on attempt 1! Retrying!
...
test_geometry_from_pubchem_live_api failed on attempt 2! Retrying!
...
test_geometry_from_pubchem_live_api failed on attempt 3! Retrying!
...
test_geometry_from_pubchem_live_api failed after 4 attempts!

Let's increase the retry delay.

The live API test still fails in CI. It ends up failing 4 times in a
row:

```
test_geometry_from_pubchem_live_api failed on attempt 1! Retrying!
...
test_geometry_from_pubchem_live_api failed on attempt 2! Retrying!
...
test_geometry_from_pubchem_live_api failed on attempt 3! Retrying!
...
test_geometry_from_pubchem_live_api failed after 4 attempts!
```

Let's increase the retry delay.
@mhucka
mhucka marked this pull request as ready for review April 24, 2026 04:25

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the retry delay for the PubChem live API test from 2 to 30 seconds to mitigate transient server errors. The feedback suggests implementing an exponential backoff strategy instead of a fixed delay to optimize CI efficiency and reduce idle time during test retries.

Comment thread src/openfermion/chem/pubchem_test.py Outdated
mhucka and others added 2 commits April 23, 2026 21:28
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@mhucka
mhucka merged commit dd3f39a into quantumlib:main Apr 24, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant