Increase the delay between PubChem retries#1284
Merged
Merged
Conversation
The live API test still fails in CI. It ends up failing 4 times in a row: ``` test_geometry_from_pubchem_live_api failed on attempt 1! Retrying! ... test_geometry_from_pubchem_live_api failed on attempt 2! Retrying! ... test_geometry_from_pubchem_live_api failed on attempt 3! Retrying! ... test_geometry_from_pubchem_live_api failed after 4 attempts! ``` Let's increase the retry delay.
mhucka
marked this pull request as ready for review
April 24, 2026 04:25
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the retry delay for the PubChem live API test from 2 to 30 seconds to mitigate transient server errors. The feedback suggests implementing an exponential backoff strategy instead of a fixed delay to optimize CI efficiency and reduce idle time during test retries.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live API test still fails in CI. It ends up failing 4 times in a row:
Let's increase the retry delay.