Skip to content

Ruff furb implementation#7907

Merged
pavoljuhas merged 12 commits intoquantumlib:mainfrom
joesho112358:ruff-furb-implementation
Feb 23, 2026
Merged

Ruff furb implementation#7907
pavoljuhas merged 12 commits intoquantumlib:mainfrom
joesho112358:ruff-furb-implementation

Conversation

@github-actions github-actions bot added the size: M 50< lines changed <250 label Feb 21, 2026
@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

❌ Patch coverage is 89.58333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.62%. Comparing base (349378a) to head (8e51f2a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dev_tools/notebooks/isolated_notebook_test.py 20.00% 4 Missing ⚠️
dev_tools/incremental_coverage.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7907   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        1104     1104           
  Lines       99339    99317   -22     
=======================================
- Hits        98963    98943   -20     
+ Misses        376      374    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

flat_new_operations = tuple(ops.flatten_to_ops(new_operations))

new_qubits = set()
new_qubits: set[cirq.LineQubit] = set()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be cirq.Qid

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I saw that in my local run, but don't really trust my local run. I have some differences locally versus the CI runs and wanted to see what it resulted in here. With the update, I get Found 293 errors in 98 files (checked 1160 source files) from FORCE_COLOR=1 check/mypy.

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pavoljuhas pavoljuhas enabled auto-merge February 23, 2026 07:51
@pavoljuhas pavoljuhas added this pull request to the merge queue Feb 23, 2026
Merged via the queue into quantumlib:main with commit 912a76e Feb 23, 2026
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M 50< lines changed <250

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants