ruff - enable and fix N805#7903
Merged
pavoljuhas merged 3 commits intoquantumlib:mainfrom Feb 20, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7903 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 1104 1104
Lines 99339 99339
=======================================
Hits 98963 98963
Misses 376 376 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pavoljuhas
requested changes
Feb 19, 2026
Collaborator
pavoljuhas
left a comment
There was a problem hiding this comment.
Let us disable that rule for the entire class instead:
diff --git a/cirq-core/cirq/ops/clifford_gate.py b/cirq-core/cirq/ops/clifford_gate.py
index 30e15dc38..375e31f42 100644
--- a/cirq-core/cirq/ops/clifford_gate.py
+++ b/cirq-core/cirq/ops/clifford_gate.py
@@ -139,4 +139,6 @@ class CommonCliffordGateMetaClass(value.ABCMetaImplementAnyOneOf):
# These are class properties so we define them as properties on a metaclass.
+ # ruff: disable[N805]
+
@property
def all_single_qubit_cliffords(cls) -> Sequence[cirq.SingleQubitCliffordGate]:
PS: Please merge with main to clean up the typecheck failure.
pavoljuhas
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding checks for #7505 :
N805 - invalid-first-argument-name-for-method
This is mostly exclusion of the rule because it conflicts with pylint in these areas