ruff - enable and fix selected RUF rules

[joesho112358]

Adding checks for #7505

RUF005 - collection-literal-concatenation
RUF015 - unnecessary-iterable-allocation-for-first-element

This resolves #7505

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[joesho112358]

@pavoljuhas I would like some input on this. It seems like this is one of those things that might not be wanted. Obviously this PR needs more work to move forward, but I wanted to call it out because it also might be a big changed for some people. A gist of the changes:

tail[::-1] + [n1, n0] + inner
# becomes
[*tail[::-1], n1, n0, *inner]

and

list(sweep.points)[0]
# becomes
next(iter(sweep.points))

I guess the call outs are GridQubits being flagged as tuples:
Example 1

Example 2

and some formatting weirdness:
Example

[pavoljuhas]

I guess the call outs are GridQubits being flagged as tuples: Example 1

You'd need to use your judgement to accept or ignore such matches. In some cases the addition should be left as is for example for GridQubit(x, y) + (a, b) which gives an offset GridQubit(x+a, y+b). Elsewhere, where the result is a tuple it makes sense to replace t1 + t2 with (*t1, *t2).

Example 2

Same thing, it should be left alone from the linter POV. BTW, that code is a bit buggy so I will submit a separate PR for that soon.

and some formatting weirdness: Example

I don't know where does that come from, perhaps some formatting feature in IDE? If you run formatter localy, make sure it is black-26.1.0.
If I restore that file back and leave only the change at line 2439

Cirq/cirq-core/cirq/contrib/qasm_import/_parser_test.py

Line 2439 in 1ca3e19

imported = next(iter(parsed_qasm.circuit.all_operations())).gate

the black --check cirq-core/cirq/contrib/qasm_import/_parser_test.py does not complain.
BTW, the iter(...) call on that line is redundant, because circuit.all_operations() is already iterator.
Please correct and look out for similar ruff-generated fixes.

[joesho112358]

Will be able to address the comments and pick this up within a week, I hope

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.62%. Comparing base (912a76e) to head (0bd2aa9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7883      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        1104     1104              
  Lines       99317    99322       +5     
==========================================
+ Hits        98944    98947       +3     
- Misses        373      375       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[joesho112358]

@pavoljuhas this looks to be the last part of #7505 (for now, i assume). feel free to flag me on anything you'd like me to update and I will get to it over the next few days

[pavoljuhas]

LGTM with a couple of tweaks pushed in.

Thank you for chipping away this stone!