(1/2) Combine Pauli measurements and postselection#7746
(1/2) Combine Pauli measurements and postselection#7746ddddddanni merged 13 commits intoquantumlib:mainfrom
Conversation
Done! |
eliottrosenberg
left a comment
There was a problem hiding this comment.
One small nit, otherwise LGTM. Thanks!
|
|
||
| circuit: circuits.FrozenCircuit | ||
| pauli_strings: list[list[ops.PauliString]] | ||
| postselection_symmetries: list[tuple[ops.PauliString | ops.PauliSum, int]] |
There was a problem hiding this comment.
Can we have this default to an empty list? That way users don't need to enter anything for postselection_symmetries if they don't want to postselect.
| """ | ||
|
|
||
| circuit: circuits.FrozenCircuit | ||
| pauli_strings: list[list[ops.PauliString]] |
There was a problem hiding this comment.
since this is a frozen class, use tuple instead
cirq-core/cirq/contrib/paulistring/pauli_string_measurement_with_readout_mitigation.py
Outdated
Show resolved
Hide resolved
|
@ddddddanni Thank you for this work. For planning purposes, could you let us know what the status of this is? It looks like it was approved and what remains is resolving some conflicts and minor nits. Is that correct? |
Hey Mike, thanks for checking!! I’m actually holding off on this until #7760 is merged. Since #7760 adds more support for calculating Pauli expectations, I want to land that first to keep the sequence of changes logical. Once that is submitted, I will immediately resolve the conflicts and nits here. |
|
Got it. Thanks! |
|
@ddddddanni Thanks for your patience! #7760 was merged recently, so it sounds like we may be ready for this PR too, whenever you get a chance to look at the pesky merge conflicts. (No pressure; just going around and checking on all PRs.) |
Sure!!! There are lots of conflicts I need to resolve ORZ, I will have it ready by this week! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7746 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 1104 1104
Lines 99325 99374 +49
=======================================
+ Hits 98949 98999 +50
+ Misses 376 375 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I split this #7492 giant PR into smaller pieces for easier review.
This PR: