Conversation
https://github.com/openworm/org.geppetto.core.git into feature/166 Conflicts: .travis.yml src/main/java/org/geppetto/core/manager/SharedLibraryManager.java
| name="Edge"/> | ||
| <types xsi:type="gep_1:SimpleType" | ||
| id="node" | ||
| name="Node"/> |
There was a problem hiding this comment.
Isn't there a risk to confuse that with the root "Node" type?
| // We add all supported versions of the schema | ||
| String[] versions = new String[] { "v1.1.0" }; | ||
|
|
||
| String[] versions = new String[] { "feature/30" }; |
There was a problem hiding this comment.
What about directly having v1.2.0 so to avoid the annoyance to change it again after the merge?
There was a problem hiding this comment.
It has to match with what's in the XMI of the common library. Which in turns has to be an existing tag or branch and 1.2.0 won't exist until we merge and release model.
There was a problem hiding this comment.
On the Python side is quite different: it is not really looking for the url, or versions, these are more placeholders that we can set as we like provided that we keep them consistent through the code
There was a problem hiding this comment.
Yeah, it's more constrained in Java and if you change that tests won't work.
| id="metadata" | ||
| name="Metadata"/> | ||
| <types xsi:type="gep_1:ConnectionType" | ||
| id="edge" |
There was a problem hiding this comment.
I thought we can put them in the Value
There was a problem hiding this comment.
I was thinking as default "class" values. Name is clearly not something we can put there though. Probably this os something we can add to types on the application directly
There was a problem hiding this comment.
Yes I was thinking that unless we are customizing them it's not needed even to add them and if we are customizing them then we can do that in other libraries or in the application
2 participants
Fixes #166