Create() does not work MPI-parallel with arrays of parameter values#3591
Open
med-ayssar wants to merge 5 commits intonest:mainfrom
Open
Create() does not work MPI-parallel with arrays of parameter values#3591med-ayssar wants to merge 5 commits intonest:mainfrom
med-ayssar wants to merge 5 commits intonest:mainfrom
Conversation
3 tasks
heplesser
requested changes
Sep 30, 2025
Contributor
heplesser
left a comment
heplesser
left a comment
There was a problem hiding this comment.
@med-ayssar Thanks for the PR, but I see some issues, see below. I wonder if we shouldn't leave the fix for PyNEST-NG—no user has complained about this ever ;).
Comment on lines
+277
to
+279
| only_local_nodes = list(itertools.compress(nodes, local_nodes)) | ||
| if len(only_local_nodes) == 0: | ||
| return |
Contributor
There was a problem hiding this comment.
I am afraid of corner cases here. If SetStatus should trigger MPI communication, but some rank never calls SetStatus in the kernel, we will hang. So I would not want to return here.
Comment on lines
+281
to
+282
| if params_is_dict: | ||
| node_params = only_local_nodes[0].get() if set_status_nodes else nodes[0].get() |
Contributor
There was a problem hiding this comment.
Here, I think the and set_status_nodes needs to stay where it is. The function here mixes in a not very good way setting node and synapse status and everything under this if, I believe, applies only to nodes.
jessica-mitchell
added
T: Bug
|
Pull request automatically marked stale! |
github-actions
Bot
added
the
stale
github-actions
Bot
removed
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3587