Skip to content

refactor: make display_order again part of the definition version content hash#232

Open
j0g3sc wants to merge 1 commit into
mainfrom
fix/bbd-io-display-order-roundtrip-2
Open

refactor: make display_order again part of the definition version content hash#232
j0g3sc wants to merge 1 commit into
mainfrom
fix/bbd-io-display-order-roundtrip-2

Conversation

@j0g3sc

@j0g3sc j0g3sc commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

📊 Test Coverage

Scope Coverage
Unit tests (mock client) 75.0%
Combined (unit + acceptance) 80.6% — ✅ acceptance passed
Uncovered functions (combined run)
github.com/meshcloud/terraform-provider-meshstack/client/api_key_permissions.go:225:							AllApiKeyPermissions					0.0%
github.com/meshcloud/terraform-provider-meshstack/client/buildingblock.go:97:								Delete							0.0%
github.com/meshcloud/terraform-provider-meshstack/client/client.go:48:									NewApiTokenAuthorization				0.0%
github.com/meshcloud/terraform-provider-meshstack/client/internal/logging.go:27:							Debug							0.0%
github.com/meshcloud/terraform-provider-meshstack/client/internal/logging.go:31:							Info							0.0%
github.com/meshcloud/terraform-provider-meshstack/client/internal/logging.go:35:							Warn							0.0%
github.com/meshcloud/terraform-provider-meshstack/client/internal/retry.go:228:								Close							0.0%
github.com/meshcloud/terraform-provider-meshstack/client/internal/retry.go:249:								Write							0.0%
github.com/meshcloud/terraform-provider-meshstack/client/project_group_binding.go:27:							Read							0.0%
github.com/meshcloud/terraform-provider-meshstack/client/project_group_binding.go:31:							Create							0.0%

Combined with go tool covdata merge over the unit and acceptance coverage data. The acceptance suite runs ./internal/provider against the live backend; coverage is attributed across all packages (-coverpkg=./...).

@j0g3sc
j0g3sc force-pushed the fix/bbd-io-display-order-roundtrip-2 branch from 49e71cb to 417f678 Compare July 13, 2026 13:17
@j0g3sc
j0g3sc requested a review from grubmeshi July 13, 2026 14:03
@j0g3sc
j0g3sc marked this pull request as ready for review July 13, 2026 14:03

@grubmeshi grubmeshi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that was essentially all that was missing, indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants