feat!: move tenant resources to the meshTenant v4 GA media type (CU-86c0j0r7q)#227
Open
grubmeshi wants to merge 2 commits into
Open
feat!: move tenant resources to the meshTenant v4 GA media type (CU-86c0j0r7q)#227grubmeshi wants to merge 2 commits into
grubmeshi wants to merge 2 commits into
Conversation
Collaborator
Author
|
Related PRs (CU-86c0j0r7q, make-tenant-v4-ga):
Merge order: meshfed PR-1 → PR-2 (deploy) → provider PR-1 (release, works via the preview alias) → provider PR-2 (GA flip). |
📊 Test Coverage
❌ Acceptance tests failed — this blocks merge. If the change needs a companion backend change, merge its meshfed-release PR first (rebuilds Uncovered functions (combined run)Combined with |
|
❌ Acceptance tests failed — this blocks merge. The job runs against the last merged meshfed-release backend ( 🔗 Failing acceptance job · companion meshfed-release PR — same branch (private; 404 without access) |
grubmeshi
force-pushed
the
feature/make-tenant-v4-ga
branch
from
July 7, 2026 20:47
73574ac to
b7485fd
Compare
grubmeshi
force-pushed
the
feature/adopt-tenant-v4
branch
2 times, most recently
from
July 7, 2026 20:53
eaec87a to
2168a82
Compare
grubmeshi
force-pushed
the
feature/make-tenant-v4-ga
branch
from
July 7, 2026 20:53
b7485fd to
c3513c3
Compare
grubmeshi
force-pushed
the
feature/adopt-tenant-v4
branch
from
July 9, 2026 20:06
2168a82 to
9da0ded
Compare
grubmeshi
force-pushed
the
feature/make-tenant-v4-ga
branch
from
July 9, 2026 20:06
c3513c3 to
28c672a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR promotes the tenant resources/data sources from the v4-preview media type to the v4 GA media type and removes the preview disclaimers from both schema descriptions and generated docs, aligning the provider with the GA meshTenant v4 endpoint.
Changes:
- Switch the tenant v4 meshObject client from
v4-previewtov4. - Remove
previewDisclaimer()from tenant-related resource/data source schema descriptions. - Regenerate/update docs and add a
v0.24.1changelog entry for the media-type flip.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/provider/tenants_data_source.go | Removes preview disclaimer from plural tenants data source schema description. |
| internal/provider/tenant_v4_resource.go | Removes preview disclaimer from deprecated meshstack_tenant_v4 resource schema description. |
| internal/provider/tenant_v4_data_source.go | Removes preview disclaimer from deprecated meshstack_tenant_v4 data source schema description. |
| internal/provider/tenant_resource.go | Removes preview disclaimer from meshstack_tenant resource schema description. |
| internal/provider/tenant_data_source.go | Removes preview disclaimer from deprecated singular tenant data source schema description. |
| docs/resources/tenant.md | Removes preview disclaimer blocks from generated resource documentation. |
| docs/resources/tenant_v4.md | Removes preview disclaimer blocks from generated deprecated resource documentation. |
| docs/data-sources/tenants.md | Removes preview disclaimer blocks from generated plural data source documentation. |
| docs/data-sources/tenant.md | Removes preview disclaimer blocks from generated deprecated singular data source documentation. |
| docs/data-sources/tenant_v4.md | Removes preview disclaimer blocks from generated deprecated v4 data source documentation. |
| client/tenant_v4.go | Switches tenant v4 client initialization to apiVersion = "v4" (GA). |
| CHANGELOG.md | Adds v0.24.1 entry documenting the breaking media-type flip and disclaimer removal. |
grubmeshi
force-pushed
the
feature/adopt-tenant-v4
branch
from
July 10, 2026 08:36
9da0ded to
456bb92
Compare
grubmeshi
force-pushed
the
feature/make-tenant-v4-ga
branch
from
July 10, 2026 08:36
28c672a to
f0cb5ec
Compare
grubmeshi
force-pushed
the
feature/adopt-tenant-v4
branch
from
July 10, 2026 09:57
456bb92 to
33540dc
Compare
grubmeshi
force-pushed
the
feature/make-tenant-v4-ga
branch
from
July 10, 2026 09:57
f0cb5ec to
be377ca
Compare
grubmeshi
force-pushed
the
feature/adopt-tenant-v4
branch
from
July 13, 2026 09:57
33540dc to
fc80215
Compare
grubmeshi
force-pushed
the
feature/make-tenant-v4-ga
branch
from
July 13, 2026 09:57
be377ca to
c5dbfd3
Compare
Reimplement meshstack_tenant on the shared v4 body (platform_ref, landing_zone_ref, platform_tenant_id, status, ref, wait_for_completion): - v3->v4 state upgrade (SchemaVersion 1): the upgrader resolves the tenant via the list endpoint (Configure runs before UpgradeResourceState) and backfills uuid + refs. - moved support from meshstack_tenant_v4 (shared body -> non-destructive). - import accepts a tenant UUID or the legacy workspace.project.location.platform composite. - singular data source reimplemented over TenantV4.List (composite key). - deprecate the meshstack_tenant_v4 resource (-> meshstack_tenant + moved) and the singular meshstack_tenant / meshstack_tenant_v4 data sources (-> plural meshstack_tenants). - rename the plural tenants data source's internal identifiers off the _v4 suffix (HCL name meshstack_tenants unchanged). Shared the v4 body schema + state mapping between meshstack_tenant and meshstack_tenant_v4. Adds a WithRawBlock test helper for moved-block configs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Flip the tenant v4 client from the v4-preview media type to GA (v4) and drop the now-obsolete preview disclaimers from the tenant resources and data sources. Behaviourally identical to the previous release (same v4 body); requires a meshStack where the meshTenant v4 API is GA. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
grubmeshi
force-pushed
the
feature/adopt-tenant-v4
branch
from
July 14, 2026 13:06
fc80215 to
0437e04
Compare
grubmeshi
force-pushed
the
feature/make-tenant-v4-ga
branch
from
July 14, 2026 13:06
c5dbfd3 to
67c195c
Compare
grubmeshi
force-pushed
the
feature/adopt-tenant-v4
branch
from
July 14, 2026 19:58
0437e04 to
b53643f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Flips the tenant resources/data sources from the
v4-previewmedia type to thev4GA media type (application/vnd.meshcloud.api.meshtenant.v4.hal+json) and removes the preview disclaimers. Behaviourally identical to v0.24.0 — same body shape.v0.24.1(patch; breaking-but-behaviourally-identical media-type flip).Stacks on B0 (#226). Requires a meshStack release where the meshTenant v4 API is GA (A2, #10309).
Cross-repo PRs
-previewclients from the GA endpoint (base of the stack)v4-preview— platform/landing-zone refs,status.lifecycle, non-null tagsmeshstack_tenanton the v4 body; deprecatemeshstack_tenant_v4