Apply all review suggestions from PR #201 (playerbot module integration)#202
Draft
Apply all review suggestions from PR #201 (playerbot module integration)#202
Conversation
…ame code Co-authored-by: billy1arm <[email protected]>
…two/server into copilot/apply-suggestions-from-pr-201
Co-authored-by: billy1arm <[email protected]>
Copilot
AI
changed the title
[WIP] Apply suggestions from PR #201
Apply all review suggestions from PR #201 (playerbot module integration)
Mar 2, 2026
|
✅ Build Mangos TWO Server 22.02.162 completed (commit 6f5e1ce366 by @Copilot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #201 introduced the playerbot/ahbot module but accumulated several bugs flagged in review. This applies all of them.
Bug Fixes
World.h:CONFIG_BOOL_ENABLE_QUEST_TRACKERwas misplaced insideeConfigUInt32Values, corrupting the uint32 config index array. Moved toeConfigBoolValues.Queue.cpp:sizeof(actions) / sizeof(ActionBasket*)on a pointer parameter evaluates to 1 or 2 (platform pointer size / 8), not the array length. Changed to null-terminated iteration:Action.cpp:NextAction::destroydeleted array elements but leaked theNextAction**array itself. Addeddelete[] actionsafter the element loop.CMakeLists.txt: Death Knight glob was stored inPlayerbot_Druidbutsource_group/LIST(APPEND)referenced undefinedPlayerbot_Death_Knight. Unified underPlayerbot_DeathKnight.WorldSession.cpp:LogoutAllBots()was called twice in the same logout path — once viaGetPlayer(), once via_player. Removed the first duplicate.Code Cleanup
ActionContext.h: Removed duplicate#include "AddLootAction.h".EmoteAction.cpp:danceandroarkeys were assigned twice, silently overwriting the first value. Renamed earlier entries todance_oneshotandroar_state.README.md: Fixed typos:user-controll→user-controlled,Decription→Description,someting→something,enlist→list,stategies→strategies.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
This change is