Skip to content

Apply all review suggestions from PR #201 (playerbot module integration)#202

Draft
Copilot wants to merge 5 commits intomasterfrom
copilot/apply-suggestions-from-pr-201
Draft

Apply all review suggestions from PR #201 (playerbot module integration)#202
Copilot wants to merge 5 commits intomasterfrom
copilot/apply-suggestions-from-pr-201

Conversation

Copy link

Copilot AI commented Mar 2, 2026

PR #201 introduced the playerbot/ahbot module but accumulated several bugs flagged in review. This applies all of them.

Bug Fixes

  • World.h: CONFIG_BOOL_ENABLE_QUEST_TRACKER was misplaced inside eConfigUInt32Values, corrupting the uint32 config index array. Moved to eConfigBoolValues.

  • Queue.cpp: sizeof(actions) / sizeof(ActionBasket*) on a pointer parameter evaluates to 1 or 2 (platform pointer size / 8), not the array length. Changed to null-terminated iteration:

    for (int i = 0; actions[i] != NULL; i++)
  • Action.cpp: NextAction::destroy deleted array elements but leaked the NextAction** array itself. Added delete[] actions after the element loop.

  • CMakeLists.txt: Death Knight glob was stored in Playerbot_Druid but source_group/LIST(APPEND) referenced undefined Playerbot_Death_Knight. Unified under Playerbot_DeathKnight.

  • WorldSession.cpp: LogoutAllBots() was called twice in the same logout path — once via GetPlayer(), once via _player. Removed the first duplicate.

Code Cleanup

  • ActionContext.h: Removed duplicate #include "AddLootAction.h".

  • EmoteAction.cpp: dance and roar keys were assigned twice, silently overwriting the first value. Renamed earlier entries to dance_oneshot and roar_state.

  • README.md: Fixed typos: user-controlluser-controlled, DecriptionDescription, sometingsomething, enlistlist, stategiesstrategies.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.


This change is Reviewable

Copilot AI changed the title [WIP] Apply suggestions from PR #201 Apply all review suggestions from PR #201 (playerbot module integration) Mar 2, 2026
@AppVeyorBot
Copy link

Build Mangos TWO Server 22.02.162 completed (commit 6f5e1ce366 by @Copilot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants