Open
Conversation
billy1arm
reviewed
Aug 3, 2021
billy1arm
reviewed
Aug 3, 2021
* disable strict version check by default
ratkosrb
reviewed
Aug 3, 2021
billy1arm
reviewed
Dec 29, 2021
Member
billy1arm
left a comment
There was a problem hiding this comment.
https://github.com/mangoszero/server/blob/master/cmake/MangosParams.cmake#L4
Will need to be changed when this is pushed to flag that there are new settings in the .conf file
Member
|
@Meltie2013 - Somehow i'd completely missed this PR. Did you ever get any feedback at all ? |
Contributor
Author
|
@billy1arm I completely forgot about this PR 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will need some decent testing to make sure we can login valid clients (e.g untouched clients) as the day you downloaded it to play on the official servers.
Original Commit from TrinityCore: TrinityCore/TrinityCore@250fcc8
Changes Made:
How to Test:
realmd.confand attempt to login. If you make it past the login screen, your client is valid.If not, you'll be greeted with a version error message.
Disclaimer:
Testing Changes:
Note: Feed back is needed and possible changes.
This change is