fix: disable ANSI color codes in test logger file output#245
Closed
gumruyanzh wants to merge 1 commit intojetzig-framework:mainfrom
Closed
fix: disable ANSI color codes in test logger file output#245gumruyanzh wants to merge 1 commit intojetzig-framework:mainfrom
gumruyanzh wants to merge 1 commit intojetzig-framework:mainfrom
Conversation
The test logger's logRequest() was passing colorized=true regardless of the output target, causing raw ANSI escape codes (e.g. \x1b[33m) to be written to log/test.log. This made log files hard to read and appeared as garbled output. Now colorization is only enabled when writing to stderr (stream mode), not when writing to a log file. Fixes #172 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log/test.logProblem
The test logger's
logRequest()was hardcodingcolorized = truefor method formatting, duration, and status code formatting. When writing tolog/test.log(file mode), this embedded raw ANSI escape sequences like\x1b[33minto the file, making it garbled and hard to read.Example corrupted output in
log/test.log:Fix
Derive
colorizedfrom the output mode:const colorized = self.mode == .stream. When the test logger writes to stderr (streammode), ANSI codes are used. When writing to a file, plain text is written.Test plan
zig buildsucceedszig build test --summary all- all 75 tests passFixes #172
🤖 Generated with Claude Code