fix: use correct stream type when initializing stderr log file#242
Closed
gumruyanzh wants to merge 1 commit intojetzig-framework:mainfrom
Closed
fix: use correct stream type when initializing stderr log file#242gumruyanzh wants to merge 1 commit intojetzig-framework:mainfrom
gumruyanzh wants to merge 1 commit intojetzig-framework:mainfrom
Conversation
Line 184 passed `.stdout` instead of `.stderr` to `getLogFile()` when initializing the stderr log file. This caused the `--log-error` option to be ignored, with both stdout and stderr logs using the same destination configuration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Environment.zigline 184:.stdout->.stderr--log-errorCLI option was being silently ignoredProblem
In
Environment.init(), the stderr log file was being initialized with.stdoutinstead of.stderr:This caused
getLogFileto useoptions.log(the stdout log path) instead ofoptions.@"log-error"(the stderr log path) for the error log file. Both log streams ended up with the same destination configuration, and the--log-erroroption was effectively ignored.Test plan
zig buildsucceedszig build test --summary all- all tests pass🤖 Generated with Claude Code