Skip to content

Error handling improvements - #162

Merged
agrare merged 2 commits into
fog:masterfrom
stejskalleos:ls/errors
Jan 16, 2026
Merged

Error handling improvements#162
agrare merged 2 commits into
fog:masterfrom
stejskalleos:ls/errors

Conversation

@stejskalleos

@stejskalleos stejskalleos commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

The raise 'string' will raise a RuntimeError class, hiding the original error class & its meaning.

ExceptionWrapper - handle 401 & 403 errors

The raise 'string' will raise a RuntimeError class,
hiding the original error class & its meaning.
@stejskalleos stejskalleos changed the title Compute.valid? Don’t suppress the original error class Error handling improvements Jan 15, 2026
@masayag
masayag requested a review from agrare January 15, 2026 10:16
@agrare

agrare commented Jan 15, 2026

Copy link
Copy Markdown
Collaborator

CI was disabled due to inactivity, I re-enabled it and kicked a master branch test. Once that finishes I'll kick this PR to run tests.

@agrare agrare closed this Jan 15, 2026
@agrare agrare reopened this Jan 15, 2026
Comment thread lib/fog/kubevirt/compute/compute.rb Outdated
@agrare agrare added the bug Something isn't working label Jan 16, 2026
@agrare
agrare merged commit 0b93fcc into fog:master Jan 16, 2026
4 checks passed
@agrare

agrare commented Jan 16, 2026

Copy link
Copy Markdown
Collaborator

I'm going to release this as a minor version bump due to the change in exception behavior of .valid?

agrare added a commit that referenced this pull request Jan 16, 2026
* Fix Compute.valid? suppressing the original error (#162)
@agrare

agrare commented Jan 16, 2026

Copy link
Copy Markdown
Collaborator

Released in v1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants