Error handling improvements - #162
Merged
Merged
Conversation
The raise 'string' will raise a RuntimeError class, hiding the original error class & its meaning.
Collaborator
|
CI was disabled due to inactivity, I re-enabled it and kicked a master branch test. Once that finishes I'll kick this PR to run tests. |
agrare
reviewed
Jan 15, 2026
stejskalleos
force-pushed
the
ls/errors
branch
from
January 16, 2026 08:34
50b765e to
83e7eff
Compare
agrare
approved these changes
Jan 16, 2026
Collaborator
|
I'm going to release this as a minor version bump due to the change in exception behavior of |
agrare
added a commit
that referenced
this pull request
Jan 16, 2026
* Fix Compute.valid? suppressing the original error (#162)
Collaborator
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
raise 'string'will raise aRuntimeError class, hiding the original error class & its meaning.ExceptionWrapper - handle 401 & 403 errors