Export translations in parallel. - #748
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Ruby exporter to write per-locale translation files concurrently when the output path uses the :locale placeholder, improving export performance and superseding the approach proposed in #733.
Changes:
- Parallelize per-locale export in
I18nJS.export_groupusingconcurrent-rubypromises. - Add
concurrent-rubyas a runtime dependency and document the behavior change in the changelog. - Update Node/TypeScript tooling metadata (TypeScript version bump, add
@types/node, addpackage-lock.json) and add a benchmark fixture ignore rule.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
lib/i18n-js.rb |
Runs per-locale write_file calls concurrently via Concurrent::Promises when :locale is present. |
i18n-js.gemspec |
Adds concurrent-ruby runtime dependency and adds a new dev dependency. |
CHANGELOG.md |
Notes the behavioral change: parallel export when :locale placeholder is used. |
package.json |
Bumps TypeScript and adds @types/node to dev dependencies. |
package-lock.json |
Introduces npm lockfile pinning dependency tree for the TS tooling. |
test/fixtures/bench/.gitignore |
Ignores generated benchmark YAML fixture files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
PRs).
two PRs otherwise).
Thoroughness
fixes.
.mdfiles, etc… affected by this change.What
Export translations in parallel.
Why
Supersedes #733.
Known limitations
N/A