Skip to content

modify videoUploader/VideoEncodingStatusChecker#55

Open
alan0x wants to merge 2 commits intofacebook:mainfrom
alan0x:m_videoUploader
Open

modify videoUploader/VideoEncodingStatusChecker#55
alan0x wants to merge 2 commits intofacebook:mainfrom
alan0x:m_videoUploader

Conversation

@alan0x
Copy link
Copy Markdown

@alan0x alan0x commented Jun 27, 2018

Method api.call return a Promise in videoUploader/getStatus, so I add a await before the call to getStatus .

Beside, also add return in ad_video/VideoEncodingStatusChecker so that external call can make a chain operation:

advideo.waitUntilEncodingReady(1000, 10000).then(status => {
    console.log(status)
    ...
})

@michaelwclark
Copy link
Copy Markdown
Contributor

Both of these changes should be considered for the next release. One is a bug fix, another is an important feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants